Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Spree::CreditCard in admin payment views and controller #5014

Open
rainerdema opened this issue Apr 14, 2023 · 0 comments
Labels
type:enhancement Proposed or newly added feature

Comments

@rainerdema
Copy link
Contributor

rainerdema commented Apr 14, 2023

Introduction

The implementation of a new payment method in Solidus Backend requires the addition of a dedicated source form to support a payment source creation/reuse.

Desired Behavior

A more generic integration approach (that maintains the logic of payment sources) is needed.

Many payment platforms currently support several types of payment methods.
So for the same Spree::PaymentMethod, we should be able to create payment sources of different types, such as cards, bank debits, bank redirects, bank transfers, etc.
For this reason, the partial source form view should be as generic as possible without specific references to the type of payment source.

Current Behavior

However, the current behavior in Solidus Backend is lacking in clearly marking these distinctions, with several references to the Spree::CreditCard payment source integration still present within views and controllers.

Some points related to what was mentioned:

Additional notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Proposed or newly added feature
Projects
None yet
Development

No branches or pull requests

1 participant