You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that combineProps throws a type error when upgrading to typescript 5.3. In typescript <=5.2, the same code worked without issues.
import{combineProps}from'@solid-primitives/props'import{Dynamic,DynamicProps}from'solid-js/web'importtype{ValidComponent}from'solid-js'constMyComponent=<TextendsValidComponent='div'>(props: DynamicProps<T>,)=>{constcombinedProps=combineProps([props])constchildren=<div>children</div>// This worked with typescript version <= 5.2 and broke in 5.3return<Dynamic{...combinedProps}>{children}</Dynamic>}exportdefaultMyComponent
Describe the bug
I noticed that
combineProps
throws a type error when upgrading to typescript 5.3. In typescript <=5.2, the same code worked without issues.Minimal Reproduction Link
https://github.com/GiyoMoon/solid-primitives-type-error
The text was updated successfully, but these errors were encountered: