Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouse typings should support SVGSVGElement as target #543

Open
edemaine opened this issue Nov 18, 2023 · 0 comments
Open

mouse typings should support SVGSVGElement as target #543

edemaine opened this issue Nov 18, 2023 · 0 comments

Comments

@edemaine
Copy link
Contributor

Describe The Problem To Be Solved

@solid-primitives/mouse currently restricts the target to be (an accessor of) HTMLElement | Window | Document. I'd like the typings to include SVGSVGElement (and maybe all/more of SVGElement), which works fine in my testing.

Suggest A Solution

The docstring actually says Element instead of HTMLElement, but this doesn't match the typings of @solid-primitives/event. I couldn't quite decipher the TargetWithEventMap magic to make this work out, but ideally you could use the same typings from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant