Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug after launch #10

Closed
shatk0vskiy opened this issue Jun 17, 2019 · 5 comments · May be fixed by #11
Closed

Bug after launch #10

shatk0vskiy opened this issue Jun 17, 2019 · 5 comments · May be fixed by #11

Comments

@shatk0vskiy
Copy link

Video: https://youtu.be/7pJKqMV4nb0
@bhdrbkc
Copy link

bhdrbkc commented Jul 24, 2019

no solution?

@herrkayser
Copy link

got the same issue.

@herrkayser
Copy link

The problem seems to be the fixed y-position of the circleView.frame in the viewDidLoad() method of the SHCircleBarController. It is set to self.tabBar.frame.origin.y - 40 which looks different for the different screen sizes.

@herrkayser
Copy link

it seems to be the result of the bottom safe are height on newer devices (X,XS,XR,...)

@herrkayser herrkayser mentioned this issue Jul 24, 2019
Open
@bhdrbkc
Copy link

bhdrbkc commented Jul 24, 2019

great,
thank you for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes initial layout problem for selected item on devices with safe area herrkayser/CircleBar
3 participants
@shatk0vskiy @bhdrbkc @herrkayser