Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website Feature]: Implement animated logo #743

Open
2 tasks done
ssandino opened this issue Feb 7, 2024 · 6 comments
Open
2 tasks done

[Website Feature]: Implement animated logo #743

ssandino opened this issue Feb 7, 2024 · 6 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed website Issues concerning Website

Comments

@ssandino
Copy link
Member

ssandino commented Feb 7, 2024

Is there an existing request for this feature?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

We currently use a static text logo on the top left of the website instead of the animated text logo.

Social Income Logo Animation.json (Lottie Export)

You can preview the animation by uploading the json file (above) to this site.

Describe the solution/feature

Adding the animated logo – this requires to use Lottie React Player. A good start is these articles: The easiest way to handle animations In React/Nextjs and How To Use Lottie Animations in a React App

The mobile view with the icon logo should not be changed.

Describe alternatives you've considered

No response

Criteria for Completion

No response

Anything else?

No response

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Social Income community
@ssandino ssandino added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed website Issues concerning Website labels Feb 7, 2024
@MoarCoding
Copy link

I'd like to work on this

@ssandino
Copy link
Member Author

ssandino commented Feb 8, 2024

Great @MoarCoding – thanks for your coding contribution!

@MoarCoding
Copy link

MoarCoding commented Feb 9, 2024

@ssandino Hi again. The linked lottie has a lot of vertical whitespace. I also feel that the left side should always be aligned with the left side of the main content which it only does at animation end. Would you like me to make a PR for including the lottie and then you can adjust said lottie the way you see fit before merging into main?

@ssandino
Copy link
Member Author

ssandino commented Feb 9, 2024

@ssandino Hi again. The linked lottie has a lot of vertical whitespace. I also feel that the left side should always be aligned with the left side of the main content which it only does at animation end. Would you like me to make a PR for including the lottie and then you can adjust said lottie the way you see fit before merging into main?

Good point. Thanks for thinking along. Yes a first PR without the perfect animation makes surely sense, hence, the code review can take place and we exchange the Lottie file later.

@RaphaelSchoen1 could you send me the original AF file? Then we could do a first version in which we cut all possible whitespace (that should already look alright) and upon do a new version, in which the animation only extends to the right.

@ssandino ssandino linked a pull request Feb 9, 2024 that will close this issue
@MoarCoding
Copy link

@ssandino PR up

@RaphaelSchoen1
Copy link

@MoarCoding @ssandino this lottie file should be better. I cropped the file and almost completely eliminated the horizontal and vertical white space. If you need anything else let me know.

Soical Income Logo Animation_2.json.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed website Issues concerning Website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants