-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Network faults during effect processing can lead to stale state data #153
Comments
erhathaway
changed the title
RFC: Network faults during effect processing can lead to state date
RFC: Network faults during effect processing can lead to state data
Jun 29, 2021
erhathaway
changed the title
RFC: Network faults during effect processing can lead to state data
RFC: Network faults during effect processing can lead to stale state data
Jun 29, 2021
Steps to reproduce either this or a similar issue:
|
@dearsaturn I think that may actually be a different bug. There is no validation on filter or sort names existing, and I think this is just putting bad data into the system which is breaking all future requests |
@dearsaturn this RFC deals with a potential bug that happens if a network fault occurs mid request during a valid filter / sort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suspect that network faults during effect processing can lead to stale state data might be an issue. There needs to be some validation if this is in fact a problem.
If it is a problem, I think a few solutions exist:
hasNetworkFault
attribute to indicate that the UI is out of dateor
request
andresponse
filter state. (This is a large change and dangerous b/c test coverage is very poor!)The text was updated successfully, but these errors were encountered: