-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question for Histogram.probabilityFor #85
Comments
Good question! I'm actually not sure why. I wish I'd commented that code 😬 I agree, it does look wrong, and seems like surely it should be But I just tried changing it to Hmm. |
Either way, that method name is clearly wrong. It's not returning the probability at all. So I'll at least fix that now. I've now also got a strong urge to do a deep dive on fixing the classifiers to produce mathematically correct results, not just intuitively correct. But all this custom classifier code is already supposed to be deprecated and replaced by a Core ML based implementation, now that Core ML is mature enough to take over. I shouldn't be putting more time into it, when that time should be going to the Core ML based replacement. Sigh. |
I just curious why use max of bins as divisor instead of sum of bins?
LocoKit/Timelines/ActivityTypes/Histogram.swift
The text was updated successfully, but these errors were encountered: