Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wakatime-cli not installed (Windows fix) #16

Open
hiq-davidholmstedt opened this issue Nov 15, 2021 · 1 comment
Open

wakatime-cli not installed (Windows fix) #16

hiq-davidholmstedt opened this issue Nov 15, 2021 · 1 comment

Comments

@hiq-davidholmstedt
Copy link

hiq-davidholmstedt commented Nov 15, 2021

I use this plugin for Git Windows and the change for path in commit #15 breaks that support!

if (( ! $+commands[wakatime] )); then  <--- This works
if ! wakatime_loc="$(type -p "$wakatime_bin")"; then <--- This does not work

Maybe some type of else check using the old logic might work.

It seems that the type -p command does not actually work on windows.
So if you get questions about this in the future that might be the issue.

@sobolevn
Copy link
Owner

sobolevn commented Nov 15, 2021

Thanks! @hiq-davidholmstedt can you please send a pr with a windows-friendly solution?
I don't have any windows machines, so I cannot test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants