Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No frame data with External Display(Portrait) #130

Open
sharimken opened this issue Mar 3, 2022 · 5 comments
Open

No frame data with External Display(Portrait) #130

sharimken opened this issue Mar 3, 2022 · 5 comments

Comments

@sharimken
Copy link

sharimken commented Mar 3, 2022

Thanks for the good tool of capturing displays. May I know if Display Orientation in Portrait supported?
I tested few situation, but only Mac OS can return the correct result:

  • Windows 11 Main Display(Portrait): return a cropped frame of portrait from "OnNewFrame", as the width and height remains the same of landscape mode. like a portrait frame masked by landscape frame, the missing part is black pixels.
  • Windows 11 External Display(Portrait): nothing return from "OnNewFrame" or "OnFrameChanged", no callback at all.
  • Ubuntu 21(Landscape): Get Frame Data, but all black pixels (maybe there is some permission issue?)
  • Macbook Pro M1 Max External Display(Portrait): Correct Frame Data, Width and Height
@smasherprog
Copy link
Owner

smasherprog commented Mar 4, 2022

i just moved to windows 11, so ill check if there are any issues with that.
linux distros should work without issue. I dont have a real linux machine to test this on however. All of my tests have been in virtual box.

Unfortunately, you would have to debug these issues yourself :( Screen capturing can have some interesting side effects in ways that I have not encountered.

Id like to expand this library to capture these new scenarios, but it requires help from people like you since I dont have the same environment setup for testing

@sharimken
Copy link
Author

sharimken commented Mar 4, 2022

i just moved to windows 11, so ill check if there are any issues with that. linux distros should work without issue. I dont have a real linux machine to test this on however. All of my tests have been in virtual box.

Unfortunately, you would have to debug these issues yourself :( Screen capturing can have some interesting side effects in ways that I have not encountered.

Id like to expand this library to capture these new scenarios, but it requires help from people like you since I dont have the same environment setup for testing

Awesome, glad to know that you have a chance to check the Win11 Portrait mode.

For Ubuntu testing, I tried installing all the required missing library and compiling the linux ".so" via CMake, with the default cmake commands "cd directory" -> "cmake ." -> "make". It looks fine since the ".so" does generate, but I am not 100% sure if it's correct or not.
I can get the monitor width/height..etc. The Linux Frame pixels are always black.

Edit: My Dual Boot Ubuntu OS and Win11 are both running with Intel CPU, RTX 3060

If you have a testing app for Linux, I'd like to help to check and run the result.

@smasherprog
Copy link
Owner

I am able to reproduce the Win11 issue so i am trying to fix that now.

@smasherprog
Copy link
Owner

It does look like theres a win11 bug in the desktop duplication. I loaded Microsoft's official demo code and it fails in the same way.

@sharimken
Copy link
Author

It does look like theres a win11 bug in the desktop duplication. I loaded Microsoft's official demo code and it fails in the same way.

Thanks for your updates.

Are you referring to this example for your Win11 test? I haven't tried their example yet, but hopefully they will fix it soon. or probably we should report the bug to them.
https://github.com/microsoftarchive/msdn-code-gallery-microsoft/tree/master/Official%20Windows%20Platform%20Sample/DXGI%20desktop%20duplication%20sample

For Linux Platform, do you have testing example or compiled ".so" from your side?
I still doubt about my cmake compile result, as it always return black pixels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants