New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme check needs to be more intelligent #8

Open

daedalus28 opened this issue Aug 11, 2017 · 0 comments

Contributor

daedalus28 commented Aug 11, 2017

It should either always be a warning, or an error if we can detect that the API has actually changed.

Some thoughts on how we can do that:

Inspect actual method exports for deltas
Inspect unit tests for changes
Inspect commit messages if we end up doing something like commitizen

In the short term, this should definitely be changed to be a warning.

daedalus28 assigned sean-clayton

daedalus28 mentioned this issue

Make readme issue a warning until we can make it more intelligent #9

Merged

sean-clayton added the A: Sean label

jrubensteinsp unassigned sean-clayton

jrubensteinsp removed the A: Sean label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment