Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate existing danger plugins #68

Open
daedalus28 opened this issue Feb 14, 2019 · 1 comment
Open

Evaluate existing danger plugins #68

daedalus28 opened this issue Feb 14, 2019 · 1 comment

Comments

@daedalus28
Copy link
Contributor

There are, apparently, a fair amount of danger plugins we should check out and see if we can either collaborate with them or even deprecate some of our "duties" wholesale.

Here are a few I found:

https://github.com/nylo-andry/danger-plugin-complete-pr
https://github.com/sogame/danger-plugin-toolbox
https://github.com/macklinu/danger-plugin-jest

They also have a first class "plugin" approach: https://danger.systems/js/usage/extending-danger.html

It's worth evaluating if this whole repo should just be converted to danger plugins.

@stellarhoof
Copy link
Member

stellarhoof commented Feb 21, 2019

I think it'd be easier for us to make duti itself a danger plugin a la https://github.com/sogame/danger-plugin-toolbox (a lodash-like toolbox plugin). Another option is to have npm subpackages, a disadvantage being cumbersome code reuse.

On deprecating some of our duties: I'm biased in favor of in-house code for simple stuff. The more complicated duti we've got is autoFix.js, which we should put more thought into to make it reusable and generic. testResults.js and browserResults.js seem good candidates to deprecate if we find alternatives. Even then I'd consider leaving them here. JS packages have an infamous churn-rate and the duti plugins you linked don't seem widely used, perhaps because the danger plugins api is so new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants