-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate existing danger plugins #68
Comments
I think it'd be easier for us to make duti itself a danger plugin a la https://github.com/sogame/danger-plugin-toolbox (a lodash-like toolbox plugin). Another option is to have npm subpackages, a disadvantage being cumbersome code reuse. On deprecating some of our duties: I'm biased in favor of in-house code for simple stuff. The more complicated duti we've got is |
There are, apparently, a fair amount of danger plugins we should check out and see if we can either collaborate with them or even deprecate some of our "duties" wholesale.
Here are a few I found:
https://github.com/nylo-andry/danger-plugin-complete-pr
https://github.com/sogame/danger-plugin-toolbox
https://github.com/macklinu/danger-plugin-jest
They also have a first class "plugin" approach: https://danger.systems/js/usage/extending-danger.html
It's worth evaluating if this whole repo should just be converted to danger plugins.
The text was updated successfully, but these errors were encountered: