Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if autoFix doesn't succeed #62

Open
stellarhoof opened this issue Jan 24, 2019 · 0 comments
Open

Throw error if autoFix doesn't succeed #62

stellarhoof opened this issue Jan 24, 2019 · 0 comments

Comments

@stellarhoof
Copy link
Member

There are two types of errors:

  • Errors relating to the PR
  • Runtime errors when executing the dangerfile

The first is fine to report in a Github comment, but it's confusing if
the second happens and circle CI reports a green status when in fact,
danger should've failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stellarhoof