-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for dark mode #81
Comments
Thanks a lot @renecotyfanboy , great proposal ! I guess that the dark mode you refer to is the dark mode from It seems that their fix just involves modifying their CSS. https://github.com/sphinx-gallery/sphinx-gallery/pull/948/files We do have the same equivalent CSS files on our side : https://github.com/smarie/mkdocs-gallery/tree/main/src/mkdocs_gallery/static so it is "just" a matter of finding what is relevant to port.... and testing it :) |
Unlike sphinx-gallery, the output representation captured with mkdocs-gallery does not change when using light/dark mode, making it hard to read in dark mode. See the following images for text and html repr :
Light-mode html :
![image](https://private-user-images.githubusercontent.com/49200287/279378256-946f3b89-0335-40f6-ab6b-5d5837bf2c33.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTA0MzQsIm5iZiI6MTcxOTE5MDEzNCwicGF0aCI6Ii80OTIwMDI4Ny8yNzkzNzgyNTYtOTQ2ZjNiODktMDMzNS00MGY2LWFiNmItNWQ1ODM3YmYyYzMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI0VDAwNDg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJlMGUyM2Q1ODkyMjA5MDk3MjY1MWUyOGZkNWI3MTIzNjg0ZjExZTUzMWM1NGExMTljZGU0ZmNlMjdmYTNmMzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.COP5w7nTOY6bWZqKAhrbbQLyonpbPeJClbor4y16GDs)
Dark-mode html :
![image](https://private-user-images.githubusercontent.com/49200287/279378350-ce3653a1-7519-4d50-a192-d58294da8477.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTA0MzQsIm5iZiI6MTcxOTE5MDEzNCwicGF0aCI6Ii80OTIwMDI4Ny8yNzkzNzgzNTAtY2UzNjUzYTEtNzUxOS00ZDUwLWExOTItZDU4Mjk0ZGE4NDc3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI0VDAwNDg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRlYmJhYjBkMDcxNzZkNjM1ODhiNWUwMzRjZTBkMDg0NTEwZjc4YTI2YzE3MzEyZDdhODVlMmFhNTdhZGExYjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.R3HYjGEjjnjXuy3suRT26DaRILmtCdWJNRFO3ZjHJ0Q)
Light-mode text:
![image](https://private-user-images.githubusercontent.com/49200287/279378423-249b3c40-1708-404e-a896-fe26a67c1cd0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTA0MzQsIm5iZiI6MTcxOTE5MDEzNCwicGF0aCI6Ii80OTIwMDI4Ny8yNzkzNzg0MjMtMjQ5YjNjNDAtMTcwOC00MDRlLWE4OTYtZmUyNmE2N2MxY2QwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI0VDAwNDg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzYzA4NmEzMmE4Y2FmMWMxNmJhODAyYTgyZWUxMWM0MDBhZGQ0ODUyYzZmYTkwODUyYjllMGUyMDEwYzEwNzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Q2nODm165T-xpYOR_h9LBi37GRc9u3cJ-UuEtiwr7YI)
Dark-mode text:
![image](https://private-user-images.githubusercontent.com/49200287/279378499-7496196d-5465-4f9f-9e8b-b643f368e57a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxOTA0MzQsIm5iZiI6MTcxOTE5MDEzNCwicGF0aCI6Ii80OTIwMDI4Ny8yNzkzNzg0OTktNzQ5NjE5NmQtNTQ2NS00ZjlmLTllOGItYjY0M2YzNjhlNTdhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI0VDAwNDg1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcwYzliNjBmNWU4NjY4Zjc2YTQyNDI3OGIyYzE5ZTJjYWZmM2UyMmE3NjJlN2EzN2MwZmQwOTExNzYyOGRmNWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vdV8703VYo3CkVQ7-zwAebu9B4YyQLZalwza2kd5_Cc)
This was fixed in sphinx-gallery/sphinx-gallery#948. I am sorry I have little experience with mkdocs and css in general so I might not be able to propose a PR for this
The text was updated successfully, but these errors were encountered: