Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ca.json edit commands #836

Open
maraino opened this issue Jan 24, 2023 · 1 comment
Open

Clarify ca.json edit commands #836

maraino opened this issue Jan 24, 2023 · 1 comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Milestone

Comments

@maraino
Copy link
Collaborator

maraino commented Jan 24, 2023

Description

Commands like step ca provisioner add default currently to use the remote configuration, aka adminAPI if the CA configured in your has it enabled. But if we want to edit a local ca.json, the usage is confusing.

This command might not edit myca.json. It will if your defaults.json doesn't point to a CA, or if it does, that CA is not up or doesn't have the adminAPI enabled.

step ca provisioner add --ca-config myca.json --type JWK --create

Currently, --ca-config is always set to $(step path)/config/ca.json. If we remove that default value, we can use edit the local file if --ca-config is passed and attempt remote edit if does not.

Optionally, although I think it will be confusing if the remote configuration is not enabled or the server is not up, we can attempt to edit $(step path)/config/ca.json if available. But that might be more backward compatible.

@maraino maraino added enhancement needs triage Waiting for discussion / prioritization by team labels Jan 24, 2023
@dopey dopey added this to the v0.24.0 milestone Feb 1, 2023
@tashian
Copy link
Contributor

tashian commented Feb 14, 2023

One workaround for this (until the next cli release) is to set a fake STEPPATH so that defaults.json is not found and no server access is attempted:

STEPPATH=/tmp step ca provisioner add --ca-config ~/.step/config/ca.json --type JWK --create

@maraino maraino modified the milestones: v0.24.0, v0.24.1 Apr 12, 2023
@maraino maraino modified the milestones: v0.24.4, v0.24.5 Jul 18, 2023
@maraino maraino modified the milestones: v0.25.0, v0.25.1 Sep 27, 2023
@hslatman hslatman modified the milestones: v0.25.1, v0.25.2 Nov 29, 2023
@hslatman hslatman modified the milestones: v0.25.2, v0.25.3 Feb 20, 2024
@hslatman hslatman modified the milestones: v0.26.0, v0.26.1 Mar 29, 2024
@hslatman hslatman modified the milestones: v0.26.1, v0.26.2 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

4 participants