Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks should not be attached to the default admin provisioner #803

Open
tashian opened this issue Nov 14, 2022 · 1 comment
Open

Webhooks should not be attached to the default admin provisioner #803

tashian opened this issue Nov 14, 2022 · 1 comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Milestone

Comments

@tashian
Copy link
Contributor

tashian commented Nov 14, 2022

We should have an issue label called "annoying edge case foot gun" for this one.

In the default case where there's only one initial admin provisioner, If a webhook is added to that provisioner, and the webhook is misconfigured or becomes unavailable, the user will effectively become locked out of provisioner configuration. I wonder if the CLI should block new webhooks on the initial admin provisioner. My hunch is that people, like me, will be tempted to add a webhook to the default provisioner so they can test out the feature.

The question is whether we address this one in code, or in the docs?

@tashian tashian added enhancement needs triage Waiting for discussion / prioritization by team labels Nov 14, 2022
@dopey dopey added this to the Backlog milestone Nov 16, 2022
@hslatman
Copy link
Member

hslatman commented Nov 16, 2022

Didn't think of this during the triage meeting, but this sounds a lot like the way a user could lock themselves out when configuring a policy. In the policy management APIs the new policy is checked to not lock out the current admin, nor the other admins, before persisting and making it active. This is done by instantiating a temporary policy engine and doing a dry run, essentially. I think a similar mechanism could work for the webhook, although there's still the case that the behavior of the system handling the webhook changes after first configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

No branches or pull requests

3 participants