Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-request] Fade in animation for multiple react-hint #35

Open
capi1O opened this issue Dec 14, 2018 · 1 comment
Open

[Feature-request] Fade in animation for multiple react-hint #35

capi1O opened this issue Dec 14, 2018 · 1 comment

Comments

@capi1O
Copy link

capi1O commented Dec 14, 2018

When using a react-hint which can be triggered by multiple elements (more than one element with data-rh attribute) and using a hide delay (delay={ hide: someDelay }), the fadeIn animation is only triggered when the first react-hint is shown (hover on one of the elements which toggles it). But if hovering onto another element before delay expires the animation does not kick in, indeed the react-hint DOM node is not removed and re-added but its position is changed (I suppose), so the animation is not triggered.

An option to avoid that would be to add a class to the react-hint when a triggering element is hovered (ex. react-hint--show) and set the CSS animation fadeIn there. Let me know if your're ok with this option so I can work on a PR.

@slmgc
Copy link
Owner

slmgc commented Dec 15, 2018

@monkeydri sounds good, that would be awesome if you can work on a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants