Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadContentInputStream.read() method returning wrong values #2800

Open
lfcnassif opened this issue Feb 10, 2023 · 1 comment · May be fixed by #2834
Open

ReadContentInputStream.read() method returning wrong values #2800

lfcnassif opened this issue Feb 10, 2023 · 1 comment · May be fixed by #2834

Comments

@lfcnassif
Copy link
Contributor

lfcnassif commented Feb 10, 2023 •
edited

The InputStream.read() contract says it should return a byte as an unsigned int in [0, 255] range when EOF is not reached. The current implementation is:
https://github.com/sleuthkit/sleuthkit/blob/sleuthkit-4.12.0/bindings/java/src/org/sleuthkit/datamodel/ReadContentInputStream.java#L41-L42

Last line should be fixed to:
return (read(buff) != -1) ? buff[0] & 0xFF : -1;
@lfcnassif
Copy link
Contributor Author

lfcnassif commented Feb 10, 2023 •
edited

This method is returning wrong values and can signal EOF before reaching it.

@lfcnassif lfcnassif changed the title Bug in ReadContentInputStream.read() method can signal false EOF early Bug in ReadContentInputStream.read() method returning wrong values Feb 10, 2023
@lfcnassif lfcnassif changed the title Bug in ReadContentInputStream.read() method returning wrong values ReadContentInputStream.read() method returning wrong values Feb 12, 2023
lfcnassif added a commit to sepinf-inc/sleuthkit that referenced this issue Jun 21, 2023
@lfcnassif
fix sleuthkit#2800: return unsigned byte by InputStream API (-1 just …
d63db59 
…if EOF)
@lfcnassif lfcnassif linked a pull request Jun 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #2800: return unsigned byte by InputStream API (-1 just if EOF) sepinf-inc/sleuthkit
1 participant
@lfcnassif