Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Response of chat.update is underspecified #49

Open
4 of 9 tasks
pluehne opened this issue Feb 15, 2021 · 0 comments
Open
4 of 9 tasks

Response of chat.update is underspecified #49

pluehne opened this issue Feb 15, 2021 · 0 comments

Comments

@pluehne
Copy link

pluehne commented Feb 15, 2021

Description

The response type of the chat.update endpoint is underspecified:

"properties": {
"channel": {
"type": "string"
},
"message": {
"properties": {
"attachments": {
"items": {
"type": "object"
},
"type": "array"
},
"blocks": {
"type": "object"
},
"text": {
"type": "string"
}
},
"required": [
"text"
],
"title": "Message object",
"type": "object"
},
"ok": {
"$ref": "#/definitions/defs_ok_true"
},
"text": {
"type": "string"
},
"ts": {
"type": "string"
}
},

Specifically, the types of message.attachments and message.blocks are set to a generic object type. I think these could be specified more narrowly, ideally using one of the already existing definitions such as #/definitions/objs_message or #/definitions/blocks.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant