-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Web Client Options #558
Labels
enhancement
M-T: A feature request for new functionality
Milestone
Comments
Also, is there any reason why the concurrency is set to |
Based on the underlying node-slack-sdk using a default of |
iancward
added a commit
to iancward/hubot-slack
that referenced
this issue
May 17, 2019
Add new HUBOT_SLACK_WEB_CLIENT_OPTS environment variable, used to configure web client options; It should be functionally similar to HUBOT_SLACK_RTM_CLIENT_OPTS, which is used to configure the RTM Client
iancward
added a commit
to iancward/hubot-slack
that referenced
this issue
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Describe your issue here.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Enhancement
It looks like, while the RTM client is configurable with
HUBOT_SLACK_RTM_CLIENT_OPTS
, this module does not expose any way to configure the web client.The code merely hard codes
maxRequestConcurrency
to1
and provides no opportunity to enable other options, such as debug logging.See https://github.com/slackapi/hubot-slack/blob/master/src/client.coffee#L29-L30.
Can something like a
HUBOT_SLACK_WEB_CLIENT_OPTS
environment variable be created and used when the web client is being initialized?The text was updated successfully, but these errors were encountered: