-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook Sending Functions Seem to Use the Regular JSON Encoder Which Escapes HTML Characters Unnecessarily #1252
Comments
Extra context: I saw this in Lines 41 to 63 in e715221
EscapeMessage function mentioned in slack/slackutilsx/slackutilsx.go Lines 53 to 59 in e715221
Not sure if this is the solution, but this is what I saw from a very shallow look at things. Please let me know if I can help in any way or if you'd like me to try and tackle this myself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened
While working on a Github action to send a release note to a Slack channel I saw that using the
PostWebhook
function causes the message to have weird characters in Slack due to the HTML escaping. For example, an apostrophe is converted to'
.Expected behavior
JSON marshaller only encodes the relevant characters as defined in the Slack documentation
Steps to reproduce
Send a webhook with an apostrophe in the body of the request. See that the resulting message has an HTML escaped symbol.
reproducible code
manifest.yaml
Not sure what this is?
Versions
v0.12.3
The text was updated successfully, but these errors were encountered: