Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment text box not shown #2155

Open
exp0l0zzz opened this issue Apr 21, 2024 · 5 comments
Open

Comment text box not shown #2155

exp0l0zzz opened this issue Apr 21, 2024 · 5 comments
Assignees
Labels
bug discussion GUI Issues in jadx-gui module
Milestone

Comments

@exp0l0zzz
Copy link

exp0l0zzz commented Apr 21, 2024

image

There is no way to write comment

@exp0l0zzz exp0l0zzz added bug Core Issues in jadx-core module labels Apr 21, 2024
@skylot
Copy link
Owner

skylot commented Apr 21, 2024

@exp0l0zzz can you try to resize window to increase height?
Looks like comment text box don't have enough space to show.
I will try to fix this dialog layout.

@skylot skylot changed the title 新版的 好像添加注释有问题 Comment text box not shown Apr 21, 2024
@skylot skylot self-assigned this Apr 21, 2024
@skylot skylot added GUI Issues in jadx-gui module and removed Core Issues in jadx-core module labels Apr 21, 2024
@skylot skylot added this to the TBD milestone Apr 21, 2024
@exp0l0zzz
Copy link
Author

image 我怎么删除这个注释?没看到按钮。这是在反编译里

@skylot
Copy link
Owner

skylot commented Apr 21, 2024

How do I delete this comment? I don't see the button

Comment dialog have a remove button, so you need to open dialog again to remove comment 🙂

@exp0l0zzz
Copy link
Author

我看到了,但是我觉得这个地方应该有所改进,我一开始有点糊涂,原来是重新点击 添加注释 按钮 才会出来

@skylot
Copy link
Owner

skylot commented Apr 22, 2024

I saw it, but I think this place should be improved. I was a little confused at first. It turns out that it only comes out when I click the Add Comment button again.

I agree, "Add comment" to edit/remove is very misleading.
Not sure how better to improve this. Maybe I will change menu entry to "Edit comment" if comment already added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug discussion GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants