-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing whitespace in domain name is URL encoded #656
Labels
bug
Something isn't working
Comments
I think it wouldn't hurt to trim whitespace from text pasted into URL fields. IIRC that's already done in the mobile ports. Maybe the URL handling code could simply reject domain names with illegal characters like whitespace. |
I think it makes sense to trim spaces at the beginning and end of the URL. If you deliberately want a space at the beginning or end of a URL, you can type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that if you have trailing whitespace in the domain name, it gets URL encoded
If you put this URL into the address bar:
gemini://gemi.dev
Lagrange converts the trailing space into%20
, creating the invalid domain namegemi.dev%20
and displays an error:I noticed this while copy+pasting a URL, which seems like a common probably where whitespace might accidentally get copied.
Consider having Lagrange to trim trailing whitespace off the URL. If you don't want to do this (so that people could have a file reachable at
gemini://example.com/%20
then consider trimming whitespace where it would not be allowed. In this case, in the domain name.The text was updated successfully, but these errors were encountered: