-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: consider disabling wheel testing always #6378
Comments
My main reason for not removing it is:
Phrased more negatively, if we remove it permanently, I would be apprehensive of irreversible release actions by accident. |
I agree with all the safety comments and it makes total sense. The poiof this issue is just noting the skips recently. To ensure a manual approval or wait period, you can consider this action, or the environment option. https://github.com/marketplace/actions/manual-workflow-approval |
Yes, good idea. Though, instead of manual approval, how about a simple time delay? Given history, I am not sure if it is feasible to insist on reviews at every release, in the sense that these might not materialize and then things get blocked through inaction. |
That's probably a lot easier, you can replace the test call with |
For every release, two PR's are created: first to disable testing full test suite and second to revert first. Is there any reason to not remove it permanently?
The text was updated successfully, but these errors were encountered: