Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove the OneHotEncoder inheritance SimilarityEncoder #811

Open
Vincent-Maladiere opened this issue Oct 31, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@Vincent-Maladiere
Copy link
Member

Problem Description

Follows up on #801

The SimilarityEncoder inherits from scikit-learn's OneHotEncoder, whose implementation might be heavy since we don't benefit from this parent class as we merely call check_X during fit.

Feature Description

Replace the inheritance with (TransformerMixin, BaseEstimator) and make the relevant small updates. This would also be the opportunity to perform some refactoring if needed.

Alternative Solutions

No response

Additional Context

No response

@Vincent-Maladiere Vincent-Maladiere added the enhancement New feature or request label Oct 31, 2023
@jeromedockes
Copy link
Contributor

also following other discussions, should this encoder be made to work on dataframes and manipulate columns by name rather than index?

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Nov 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants