-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Remove the OneHotEncoder
inheritance SimilarityEncoder
#811
Labels
enhancement
New feature or request
Comments
also following other discussions, should this encoder be made to work on dataframes and manipulate columns by name rather than index? |
also following other discussions, should this encoder be made to work on dataframes and manipulate columns by name rather than index?
Ideally, it would work on dataframes and arrays, don't you think?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Description
Follows up on #801
The
SimilarityEncoder
inherits from scikit-learn'sOneHotEncoder
, whose implementation might be heavy since we don't benefit from this parent class as we merely callcheck_X
duringfit
.Feature Description
Replace the inheritance with (
TransformerMixin
,BaseEstimator
) and make the relevant small updates. This would also be the opportunity to perform some refactoring if needed.Alternative Solutions
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: