New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Minor) CSS bug in dark mode in tables, on circleCI #805

Open

GaelVaroquaux opened this issue Oct 25, 2023 · 1 comment

Labels

documentation no changelog needed

Member

GaelVaroquaux commented Oct 25, 2023 •

edited

Describe the issue linked to the documentation

In dark mode, tables render wrong on circleCI:

The page https://output.circle-artifacts.com/output/job/13951c90-e23c-4688-9259-023169cb60d8/artifacts/0/doc/api.html does not render well

Problem here also:
https://output.circle-artifacts.com/output/job/13951c90-e23c-4688-9259-023169cb60d8/artifacts/0/doc/generated/skrub.SelectCols.html#skrub.SelectCols

Suggest a potential alternative/fix

Maybe it should be fixed in the CSS. Maybe it's not a big problem as it only happens on circleci and not on the main website.

@choldgraf maybe this comes from the sphinx pydate theme? Are we doing something wrong?

GaelVaroquaux added documentation no changelog needed labels

GaelVaroquaux changed the title ~~CSS bug in dark mode in API reference~~ (Minor) CSS bug in dark mode in tables, on circleCI

choldgraf commented Oct 26, 2023

I think you've found a bug in the dark theme CSS! I see the same here: https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/kitchen-sink/api.html

Opened an issue here:

[dark mode] Tables have light background and low contrast pydata/pydata-sphinx-theme#1543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment