Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inaccurate headings and readme saying Deploy to a production environment based on labels #55

Closed
gitgithan opened this issue Sep 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gitgithan
Copy link
Contributor

gitgithan commented Sep 14, 2023

In 5-deploy-to-prod-environment.md it says Step 5: Deploy to a production environment based on labels.
In X-finish.md it says Deploy to a production environment based on labels.

However the exercises never deployed to production based on labels. It was based on push to main in
.github/workflows/deploy-prod.yml

name: Deploy to production

on:
  push:
    branches:
      - main

Descriptions may have been outdated.

@gitgithan gitgithan added the bug Something isn't working label Sep 14, 2023
@hectorsector
Copy link
Contributor

Thanks for the report, @gitgithan! This is working as intended - although I realize it's a little confusing. The process overall was triggering a workflow to deploy based on labels, it just so happens this last step doesn't use labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants