Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs tabs with Skeleton-Next React Tabs #2591

Closed
Tracked by #2353
Mahmoud-zino opened this issue Apr 5, 2024 · 1 comment
Closed
Tracked by #2353

Update docs tabs with Skeleton-Next React Tabs #2591

Mahmoud-zino opened this issue Apr 5, 2024 · 1 comment
Assignees
@endigo9740
Labels
documentation Improvements or additions to documentation feature request Request a feature or introduce and update to the project.
Milestone
v3.0 (Next)

Comments

@Mahmoud-zino
Copy link
Sponsor Contributor

Describe the feature in detail (code, mocks, or screenshots encouraged)

We want to switch the docs tabs with the new implementation of Skeleton-Next React tabs.

What type of pull request would this be?

Docs

Provide relevant links or additional information.

No response
@Mahmoud-zino Mahmoud-zino added documentation Improvements or additions to documentation feature request Request a feature or introduce and update to the project. labels Apr 5, 2024
@Mahmoud-zino Mahmoud-zino added this to the v3.0 (Next) milestone Apr 5, 2024
@endigo9740
Copy link
Contributor

endigo9740 commented Apr 5, 2024 •
edited

Astro has some quirks when it comes to how children slots work within the Astro environment (or MDX). We'll attempt to use the Tabs component directly, otherwise we'll need to create a facsimile via Astro. Basically an doc-only Astro or React component that resembles the default Skeleton Tabs design.

@endigo9740 endigo9740 changed the title Next: Switch docs tabs with Skeleton-Next React Tabs Update docs tabs with Skeleton-Next React Tabs Apr 11, 2024
@endigo9740 endigo9740 mentioned this issue Apr 11, 2024
Open
35 tasks
@endigo9740 endigo9740 mentioned this issue May 24, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endigo9740 endigo9740

Labels
documentation Improvements or additions to documentation feature request Request a feature or introduce and update to the project.
Projects
None yet
Milestone
v3.0 (Next)
Development

No branches or pull requests
2 participants
@endigo9740 @Mahmoud-zino