-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar (initials only) in AppBar rendering improperly in Safari #2408
Comments
Hey @fnimick, sorry for the delay on this one. Can you confirm if the issue is still present? I'm unable to replicate: I tested both with the Note the version of Safari I'm running is listed in the screenshot. Safari versions are tied to the version of MacOS you're running. In my case I'm on |
@endigo9740 why not simply remove Even if new versions of Safari fix the problem, we still need to support old ones. |
I agree, which is why I asked if you could replicate on an older OS to confirm the issue is still present. I don't make assumptions that changes will fix things, I work on empirical data. But it would be helpful to have confirmation as I cannot easily roll back my operating system version. I'll make the change next time I have a chance to work on v2 issues, otherwise I will accept a PR - which will come with a preview URL we can verify against. |
Ah, I understand. I've also updated and can't test with old safari versions anymore, unfortunately. |
Current Behavior
Adding an with initials rather than image (which was fixed in #2333) causes the bar contents to render in the vertical center of the viewport.
The issue is the
h-full
class which was removed for image avatars, but not removed for text avatars.See also: #2055
Expected Behavior
No response
Steps To Reproduce
No response
Link to Reproduction / Stackblitz
No response
More Information
No response
The text was updated successfully, but these errors were encountered: