-
-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search suggestion is enabled even without full search terms #723
Labels
Comments
You are right, suggestSearchTerms should only be called with a non null "search" parameter, otherwise it will throw NPE inside. Could you do a PR please? |
Thanks, I'll do a PR after #722 is merged to avoid any conflict risk |
archiloque
changed the title
Search suggestion is enable even without full search terms
Search suggestion is enabled even without full search terms
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
com.sismics.docs.core.util.indexing.LuceneIndexingHandler#findByCriteria
I found this code:It means that if
criteria.getSimpleSearch()
is filled andcriteria.getFullSearch()
isnull
,suggestSearchTerms
is called with anull
parameter. It feels wrong => in this case should the suggestion search be skipped ?The text was updated successfully, but these errors were encountered: