-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sinon not throwing the error that been thrown when the error is undefined and also fail to assert #2471
Comments
So ... we should detect that a function has thrown, but if the exception is undefined, we should still regard it as thrown? |
yes, as the function being thrown should not be dependable on the value that was thrown |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Describe the bug
If the function throw
undefined
then:sinon.assert.threw(a);
failTo Reproduce
ReplIt Link
Expected behavior
As said in the docs about the 2nd thing:
Context (please complete the following information):
The text was updated successfully, but these errors were encountered: