-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing throwOnError
option for comprehensive promise chain results
#70
Comments
I agree that this functionality would be useful, but I'm not 100% sure about the For now, you could use |
I agree that it sounds similar to I will create a PoC package and let you review it so that later on we can include that in your repo. |
I think this package is missing an important functionality, and that is to see the results of resolved promises when one of the promises from the promise chain gets rejected. When
stopOnError
is set tofalse
if some of the promises are rejected, I am not able to get fulfilled results, instead, the error is thrown.It would be good to have similar behavior like
Promise.allSettled
to see the results of the promises and their status. EG if resolved, we can see the resolved result and if rejected we can see the error.Maybe we can have an additional option,
throwOnError
which will be true by default to not break the functionality, but have the ability to have the functionality explained above.I am happy to open a PR if you would like to include this functionality in your package.
The text was updated successfully, but these errors were encountered: