Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dot-prop dependencies to v7 #265

Open
raphaelmenges opened this issue Aug 15, 2023 · 2 comments
Open

Upgrade dot-prop dependencies to v7 #265

raphaelmenges opened this issue Aug 15, 2023 · 2 comments

Comments

@raphaelmenges
Copy link

raphaelmenges commented Aug 15, 2023

Hello 馃憢

To my understanding, you, @sindresorhus, use internally your own package dot-prop? According to my package-lock.json, that package is included as "dot-prop": "^6.0.1". However, I need to access array items by index using dot notation for store migration between versions. This seems to be a feature that you added in version 7 of dot-prop. Could you upgrade the (sub-) dependency in electron-store accordingly?

Using the overrides feature of npm as follows leads to below error:

"overrides": {
  "dot-prop": "7.2.0"
 }

Uncaught Exception:
Error [ERR_REQUIRE_ESM]: require() of ES Module

Cheers,
Raphael

@sindresorhus
Copy link
Owner

dot-prop 7 requires ESM and Electron does not yet support that. This issue is blocked by electron/electron#37535.

@iamterryclark
Copy link

Hasn't this been merged in to electron now?

Are there plans to update electron-store in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants