Add an option to force the relaunch of the app #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
May 21, 2019
| @@ -65,6 +65,12 @@ Watch files used in the renderer process and reload the window when they change. | |||
|
|
|||
| Setting this to `false` can be useful if you use a different reload strategy in the rendererer process, like [`HMR`](https://webpack.js.org/concepts/hot-module-replacement/). | |||
|
|
|||
| ##### forceRelaunch | |||
There was a problem hiding this comment.
This makes it sound like it's force-relaunching instead of what you mean, which is forcing it to relaunch. I think naming it alwaysRelaunch would be clearer.
| Type: `boolean`<br> | ||
| Default: `false` | ||
|
|
||
| Allways relaunch the app even when the changes don't need it. |
There was a problem hiding this comment.
Suggested change
| Allways relaunch the app even when the changes don't need it. | |
| Always relaunch the app even when the changes don't need it. |
There was a problem hiding this comment.
Also include the use-case for this option. It's not clear to a user encountering this option what they would use it for.
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4