Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should respect current file settings #54

Open
heptal opened this issue May 25, 2016 · 2 comments
Open

Plugin should respect current file settings #54

heptal opened this issue May 25, 2016 · 2 comments

Comments

@heptal
Copy link

heptal commented May 25, 2016

The current window setting should supersede the settings in .editorconfig

Let's say .editorconfig says to indent using spaces. When I edit a file and uncheck 'Indent Using Spaces' in the UI:


And Convert Indentation to Tabs:

Upon save it uses the .editorconfig settings instead of the UI setting I just set before saving to disk, and then reverts it:

This forces me to temporarily disable the plugin or edit my .editorconfig just to save a file with a non-normal indentation configuration.

@kevva
Copy link

kevva commented May 25, 2016

This was added in #19 due to new files not getting the settings from .editorconfig, and I think this is the expected behavior tbh.

@heptal
Copy link
Author

heptal commented May 26, 2016

Hmm, well that issue talks about using on_post_save, but the revert happens before save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants