Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License addition doesn't work on macOS Big Sur #62

Open
ghost opened this issue Jan 18, 2021 · 6 comments
Open

License addition doesn't work on macOS Big Sur #62

ghost opened this issue Jan 18, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented Jan 18, 2021

Version: 5.3.0

When I'm trying to add license.txt it fails with the following message:

✖ Code signing failed. The DMG is fine, just not code signed.
hdiutil: unflatten: verb not recognized
Usage: /usr/bin/hdiutil <verb> <options>
<verb> is one of the following:
help
attach
detach
eject
verify
create
compact
convert
burn
info
checksum
chpass
erasekeys
imageinfo
isencrypted
makehybrid
mount
mountvol
unmount
plugins
resize
segment
pmap
udifderez
udifrez

It seems to be a known issue and here's how it's fixed in electron-builder.

@ardaa
Copy link

ardaa commented Jan 18, 2021

What is your npm version? Did you try updating npm and electron-builder to the latest version? Seems like an issue with electron-builder.

@ghost
Copy link
Author

ghost commented Jan 18, 2021

What is your npm version? Did you try updating npm and electron-builder to the latest version? Seems like an issue with electron-builder.

My npm version is 6.14.8, but I think it's irrelevant, electron-builder is not used in this project anyway I've just used it for the reference.

I believe the problem is in this piece of code:

await execa('/usr/bin/hdiutil', ['unflatten', tempDmgPath]);

There's no unflatten verb in hdiutil on macOS Big Sur.

@sindresorhus
Copy link
Owner

There's a solution in https://stackoverflow.com/a/64836269/64949

@ghost
Copy link
Author

ghost commented Feb 1, 2021

Fellow @create-dmg devs have recently added create-dmg/create-dmg@f75cc03 to solve the same issue.

critocrito added a commit to critocrito/ncube that referenced this issue May 31, 2021
The DMG creation broke and is documented here:
sindresorhus/create-dmg#62. I switched to
`create-dmg` for generating the images instead.
dxdc added a commit to dxdc/create-dmg that referenced this issue Nov 20, 2021
@dxdc
Copy link
Contributor

dxdc commented Nov 20, 2021

For a working fix, albeit maybe short-term: #66

@kafeg
Copy link

kafeg commented Oct 26, 2023

As I understand, alternate solution is to disable license addition in this project and use separate executable to add license from here: https://github.com/argv-minus-one/dmg-license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants