Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF preview feature #136

Open
arggh opened this issue Sep 19, 2019 · 5 comments
Open

GIF preview feature #136

arggh opened this issue Sep 19, 2019 · 5 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement New feature or request help wanted Extra attention is needed

Comments

@arggh
Copy link

arggh commented Sep 19, 2019

Issuehunt badges

I think previewing the gif in the same screen where I tweak the conversion settings is a superior user experience compared to going back and forth between the settings-view and the save-view. Especially, since there is already a video player present in the settings-view.

For example, there could be a button Render preview or a toggle: Original - Preview

If you select Preview, the original video would be replaced with the gif and a progress indicator, that would let me know whenever gifski is busy converting a new preview. Tweaking the settings would start the preview conversion from scratch.

This would make it effortless to tweak the quality and framerate settings.

Another idea to speed up the preview process: how about rendering just the first frame of the gif with the settings applied? That should be plenty fast, and you would get some perspective into what the final result will look like, given the resolution and quality. Maybe even let the user scrub-select frames and render them as needed?


IssueHunt Summary

Backers (Total: $65.52)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@sindresorhus
Copy link
Owner

sindresorhus commented Jun 27, 2020

I agree, it's a bit cumbersome at the moment if you need to tweak settings.

or a toggle: Original - Preview

This sounds like a great idea indeed.

Another idea to speed up the preview process: how about rendering just the first frame of the gif with the settings applied?

Or maybe 5 frames evenly spread out over the video time range. That way you can quickly get a feel of the image quality of the whole video.

Maybe even let the user scrub-select frames and render them as needed?

I think the optimal rendering steps would be:

  1. Render first frame.
  2. Render the next 4 frames, evenly spread out.
  3. Start rendering the whole thing for real.
  4. Also allow scrubbing to render one frame at the scrubbed position.

If anyone wants to work on this, even just step 1 would be a good improvement.

The feature should be fully in SwiftUI and be embedded in the Storyboard using a NSHostingView.

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Jun 27, 2020
@sindresorhus sindresorhus changed the title GIF Preview feature GIF preview feature Jun 27, 2020
@issuehunt-oss
Copy link

issuehunt-oss bot commented Nov 8, 2021

@sindresorhus has funded $2.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Nov 8, 2021
@issuehunt-oss
Copy link

issuehunt-oss bot commented Nov 8, 2021

@sindresorhus has funded $63.52 to this issue.


@kornelski
Copy link
Collaborator

Because gifski tries to encode differences between frames, non-consecutive frames will look a bit different than in the full anim.

How about starting encoding from the start and allowing viewing everything that has been encoded so far?

@hazeycode
Copy link

Is anyone already working on this? I can take a shot at it if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants