-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: SSP SP-metadata doesn't contain 'entityid' key #1805
Comments
The question this raises with me is why it needs the extra key in the first place. Since the entityID is already in the array index, so why does it need to be duplicated. |
Agreed, we should be able to get rid of the key everywhere and just use the array index. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The SP-metadata (SSP-array style) does not contain the 'entityid' key.
This is problematic, because some code depends on it (i.e. https://github.com/simplesamlphp/simplesamlphp/blob/master/src/SimpleSAML/Metadata/MetaDataStorageHandler.php#L377), effectively breaking HTTP-Artifact binding and possibly more.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
An 'entityid' key
Additional context
The text was updated successfully, but these errors were encountered: