New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict between Clear event and Save event #306
Comments
sorry, I didn't realize some of my sentences were removed on this topic. I updated sentences in "What is the current behavior?" |
Hey :) Thank your for investing some time into this issue, the reason behind fireing the |
Having the same problem please fix this before archiving project. |
What is the current behavior?
why click on the clear button would fire save event? It creates unwanted behavior.
also related to this:
if we use color on save event something like this:
when clicking on the clear button it would throw an error in console.log because after clicking on the clear button it would fire save event and because the color is null it would throw an error in this situation and every code in the clear event gets ignored and won't run.
Please provide the steps to reproduce and create a JSFiddle.
in this example, I added an alert to "save event". after clicking on the clear button, an alert is shown. it is an undesired behavior
Please provide the steps to reproduce and create a JSFiddle.
Click on clear button would throw an error because the clear button is calling save but the color is null now.
Meanwhile in this mode, if we have some code on the clear event, they won't run.
What is the expected behavior?
clear button should not fire save event. we may encounter other problems later.
also if we use
color.toRGBA()
on save event it should not throw an error after clicking on clear button, also codes on the clear event in this situation should run.temporary fix to this issue is using
instance._color.toRGBA()
on save event if we want to use the clear button as well. but firing save event is still the main problem.Your environment:
The text was updated successfully, but these errors were encountered: