-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider releasing a 0.65 with some forwards compatibility for 1.0 #2335
Comments
Option 1. is where we are now, and it's beginning to suck. Option 2 is plausible? My What's the minimal work I could do for option 3 to be worthwhile I wonder? |
After browsing through 0.64.6...1.0a13 a bit I think a full forward-porting of the permissions work would be too hard. But having a The rest of the problem could then be solved in from datasette_test import Datasette
ds = Datasette(
plugin_config={"datasette-extract": "..."},
permissions={"manage-secrets": {"id": "admin"}}
) Where that |
Refs #4, #5 Refs simonw/datasette#2335
With 1.0 growing ever closer, I'm running into some problems with plugins. datasette-secrets is currently only compatible with 1.0a+ because of the way it uses the new permissions infrastructure from 1.0. But I want a bunch of other plugins to make use of
datasette-secrets
:And this means that those plugins will stop working with Datasette <1.0 due to that dependency.
I looked into changing
datasette-secrets
to be compatible with both versions and it's a tiny bit inconvenient mainly because the test suite uses some conveniences in 1.0 - this for example:That
permissions
piece of configuration is a much more convenient way of testing permissions.Some options:
0.65
which backports some of these conveniences from 1.0, such that it's pleasant and easy to write tests that work in bothI already have a good pattern for running CI against both versions, as seen here: https://github.com/simonw/datasette-configure-fts/blob/1.1.3/.github/workflows/test.yml
The text was updated successfully, but these errors were encountered: