Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding this plugin breaks github actions #117

Open
pitis opened this issue Nov 30, 2023 · 2 comments
Open

Adding this plugin breaks github actions #117

pitis opened this issue Nov 30, 2023 · 2 comments

Comments

@pitis
Copy link

pitis commented Nov 30, 2023

Hello there,
I've been using this module for a long time, but now when I upgraded to prettier 3.1.0 and to 3.2.4 of this package, everything works fine but on github actions. For reference, my .prettierrc:

{
  "semi": false,
  "singleQuote": true,
  "trailingComma": "es5",
  "plugins": ["prettier-plugin-organize-imports"]
}

and my github action

name: static checks

on:
  pull_request:
  push:
    branches:
      - main

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

jobs:
  static-checks:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v2
        with:
          node-version: '20'
          cache: 'npm'
      - run: npm i
      - run: npm run format:check
      - run: npm run lint

this all worked fine before and also works fine if I remove the plugins array

@simonhaenisch
Copy link
Owner

need more info:

  • which versions did you upgrade from?
  • what's the error?

@pitis
Copy link
Author

pitis commented Dec 1, 2023

@simonhaenisch sorry for not specifying before, the plugin version before was "2.3.4".
The error is it finds some files that are not formatted and it can't run, but when I run the checker or the formatter on local machine, it says no changes need to be made.

I will try to get today an example repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants