Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] type support #65

Open
ghostdevv opened this issue Mar 12, 2022 · 4 comments
Open

[feature] type support #65

ghostdevv opened this issue Mar 12, 2022 · 4 comments
Labels
feature request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghostdevv
Copy link

Currently there are no types shipped with the package, would be nice to do this

@ghostdevv ghostdevv added bug Something isn't working investigating Not quite sure if it's valid, yet labels Mar 12, 2022
@ghostdevv
Copy link
Author

In terms of options to auto generate types, you can either stick with the current rollup build system and use sveld to generate types. Or you can switch to sveltekit package and use that to build the package

@simeydotme simeydotme added feature request and removed bug Something isn't working labels Mar 12, 2022
@simeydotme simeydotme added help wanted Extra attention is needed good first issue Good for newcomers and removed investigating Not quite sure if it's valid, yet labels May 26, 2022
@i7N3
Copy link

i7N3 commented Nov 4, 2022

I've created a type definition. You can add it as dev dep.
https://www.npmjs.com/package/@types/svelte-range-slider-pips

@simeydotme
Copy link
Owner

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

Thanks @i7N3 ... is this a normal/accepted way to handle the issue? And if so is the issue closable? Or should the types be defined inside the repo?

@i7N3
Copy link

i7N3 commented Nov 5, 2022

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

Thanks @i7N3 ... is this a normal/accepted way to handle the issue? And if so is the issue closable? Or should the types be defined inside the repo?

As someone mentioned here, there is a better way to rewrite svelte-range-slider-pips to typescript.

@simeydotme simeydotme added this to the Svelte 4+ , Typescript milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants