Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native support for CLA sign-off (starting with DCO) #326

Open
marshall007 opened this issue May 30, 2023 · 2 comments
Open

Native support for CLA sign-off (starting with DCO) #326

marshall007 opened this issue May 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@marshall007
Copy link

Description

https://en.m.wikipedia.org/wiki/Developer_Certificate_of_Origin

I believe the typical requirement for DCO commits is the same as committer verification in gitsign (i.e. that the identity matches the commit author).

I think there are two integration points worth considering:

  1. when a commit message contains a Signed-off-by line, enable gitsign.matchCommitter unless it is explicitly set to false
  2. add support for specifying well-known CLAs in the form of extra scopes requested during the OAuth flow

Perhaps these scopes could be specified in the form of URNs (ex. urn:sigstore:gitsign:cla:dco)? Sigstore can then present the requested CLA(s) to the developer on the OAuth consent screen.

TBD how we map the acceptance of requested scopes into the JWTs and ultimately the signing certificate.

@marshall007 marshall007 added the bug Something isn't working label May 30, 2023
@marshall007
Copy link
Author

The idea would be to replace integrations like the DCO GitHub App with something like gitsign verify ... --cla dco.

@wlynch
Copy link
Member

wlynch commented May 31, 2023

🎉 I like it!

We've been a bit resistant to recommending gitsign as a replacement for DCO, since cryptographic signing serves a different purpose than the DCO sign-off (i.e. signing something w/ your identity doesn't mean you agree to a CLA), but I like the idea of using an extra scope to signify the DCO consent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants