Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move C declarations to a .pxd file to be available to other Cython modules. #59

Open
Mng-dev-ai opened this issue Jan 24, 2022 · 7 comments

Comments

@Mng-dev-ai
Copy link

I think It would be great if you move the c declarations to a .pxd file to be available to other cython modules as in my case I don't need to use it as a python module to minimize the python interactions as possible.

@siddhantgoel
Copy link
Owner

It could be a good idea. Could you please describe your use case a bit more?

@Mng-dev-ai
Copy link
Author

Mng-dev-ai commented Feb 6, 2022

I'm working on a cython project and I'm gonna use your package so I wanna be able to import it as a cython module which is not possible without using .pxd file

@Mng-dev-ai
Copy link
Author

I may can work on a pr if you want

@siddhantgoel
Copy link
Owner

Yeah that would be helpful. And as I understand, you're planning to move only the C declarations to that file, right? So the Finder and _Parser classes stay?

@Mng-dev-ai
Copy link
Author

Yes, the class itself will be the same but the declarations such cdef bytes target will be moved.

@siddhantgoel
Copy link
Owner

Sounds good. Let's do it!

@Mng-dev-ai
Copy link
Author

Done at #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants