Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Merged Api Support #605

Open
SethO opened this issue Jun 23, 2023 · 3 comments
Open

Feature Request: Merged Api Support #605

SethO opened this issue Jun 23, 2023 · 3 comments

Comments

@SethO
Copy link

SethO commented Jun 23, 2023

I wanted to start a discussion about how this project evolves given the newly available AppSync Merged APIs.

One approach could be to use one API definition per source API and one for the merged API. The last would be a convenient "wrapper" over the CloudFormation needed to set one up.

Another approach could be something closer to what v1 of this plugin supported where we define multiple APIs in the same definition and then include the merged API to stitch it all together.

I look forward to the conversation.

@bboure
Copy link
Collaborator

bboure commented Jun 29, 2023

Thank you @SethO

This is something I want to support.
I still need to figure out how this all works with CloudFormation but it seems like two key parameters are ApiType
and MergedApiExecutionRoleArn

Another approach could be something closer to what v1 of this plugin supported where we define multiple APIs in the same definition and then include the merged API to stitch it all together.

My first impression is that we should probably not do that.
In theory, the merge feature is meant to be used when several teams work together. This means that each team would own and maintain their own stack (i.e. their own servelress.yml file).

I will try to find some time to investigate all this.

@SethO
Copy link
Author

SethO commented Jul 1, 2023

I've got a working GitHub example of the CloudFormation here. There are mistakes in the current AWS CFN documentation that I'll highlight in an upcoming blog article on the subject (with links to this repo, I might add). I'll post a link in this thread when it's published.

@SethO
Copy link
Author

SethO commented Jul 3, 2023

Here is the blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants