-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class::method need to be refactored #5049
Labels
Milestone
Comments
This actually doesn't look that bad...everything is in the lines of |
@karlnapf this is just for classifiers, there should be more coming up soon. |
LiuYuHui
changed the title
Class::method need to be reactored
Class::method need to be refactored
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current shogun Machine class store the label and the features, this implementation makes the class became stateful, it is great that refactor the Machine class and the derived class to became stateless.
The basic idea is that find all the method that accesses m_labels/m_features and use the parameters passed in instead.
here is all the class::method needs to be refactored, those methods are found by this libtooling script.
The text was updated successfully, but these errors were encountered: