Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting when ubuntu launchpad is down? #834

Open
1 task done
SystemKeeper opened this issue Apr 18, 2024 · 6 comments
Open
1 task done

Improve error reporting when ubuntu launchpad is down? #834

SystemKeeper opened this issue Apr 18, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@SystemKeeper
Copy link

Describe the feature

Today ubuntu launchpad went into maintenance (see https://ubuntu.social/@launchpadstatus/112286753813553221) and installation of php failed because of that:

image

I am wondering if it would be possible to output a message that indicates why the installation failed in that case?

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Describe alternatives

I guess there's no alternative instead of guessing what happens.

Are you willing to submit a PR?

Yes in general, but never looked at the setup-php code in more detail.

@SystemKeeper SystemKeeper added the enhancement New feature or request label Apr 18, 2024
@shivammathur
Copy link
Owner

@SystemKeeper

I plan to add a mirror for the PPA we use as a fallback to avoid this in future.

@rukaelin
Copy link

Hi there, we experienced the same issue last week. it's great to see that you are working on this, thank you @shivammathur 🙏

@samansupriadi
Copy link

samansupriadi commented Jun 10, 2024

Hi i have similiar issue

image

thank you @shivammathur

@shivammathur
Copy link
Owner

@samansupriadi Please create a separate issue with details about your workflow.

@dac-humi
Copy link

Hello, thank you for your work on this repo. It is very much appreciated. 🙏

Major PPA outage today triggering fail. Acknowledged by Canonical here.

Although you said:

I plan to add a mirror for the PPA we use as a fallback to avoid this in future.

I think this ticket is more about showing some logs when an incident like this occurs. Right now, we have to trigger by changing shivammathur/[email protected] to shivammathur/setup-php@verbose@verbose

Then I see a massive dump that includes the one line I care about:

Cannot initiate the connection to ppa.launchpad.net:80 (2620:2d:4000:1::81). - connect (101: Network is unreachable)

Would be nice if error was shown without verbose.

@shivammathur
Copy link
Owner

@dac-humi

I understand that, but to display that error in the apt-get update command it is required to change how logs are piped in the action and that change is not trivial, and I cannot work on that right now.

It would be much easier for me to maintain a fallback mirror for the PPA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants