Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionFailed uncaught exception #364

Open
diogeneshamilton opened this issue Feb 1, 2024 · 12 comments
Open

TransactionFailed uncaught exception #364

diogeneshamilton opened this issue Feb 1, 2024 · 12 comments

Comments

@diogeneshamilton
Copy link

Getting this sometimes, after the connection is open for a while or it tries to reconnect:
Screenshot 2024-02-01 at 11 41 12 AM

Is there any way to prevent this error or catch it so it doesn't crash the server?

@diogeneshamilton
Copy link
Author

It appears werift is not handling a 438 stale nonce response correctly? I see they handled it in aioice:
aiortc/aioice#28

@shinyoshiaki
Copy link
Owner

Thanks for the report, werift-ice has a similar problem because it references the old aioice code. I will fix it.

@diogeneshamilton
Copy link
Author

Awesome, thank you!

@diogeneshamilton
Copy link
Author

Not trying to rush or be difficult, but curious what the timeline might be for fixing this? I'm still having issues here and want to either catch the exception or the library doesn't throw it.
Any other workarounds you can suggest?

@shinyoshiaki
Copy link
Owner

I've been busy lately, so a fundamental solution will take time.
If I just avoid throwing exceptions, I think it can be accomplished relatively quickly.
However, it is not a fundamental solution and there will still be problems using the TURN feature.
Just to confirm, are you sure you are not using the TURN function?
If not using, I think the problem can be solved by simply not using TURN when setting up peerConnection.

@diogeneshamilton
Copy link
Author

To be clear, we are using TURN function. Maybe we're not implementing it correctly? Either way, thanks for the responses and we'll make do in the meantime!

@diogeneshamilton
Copy link
Author

I guess I was a bit quick to close this issue- it seems this happens right after a connection is closed, is there any thing I can do in addition to connection.close() that would stop this from happening?

@shinyoshiaki
Copy link
Owner

@diogeneshamilton 438 error handling is now supported

@diogeneshamilton
Copy link
Author

Amazing, thank you! I will look out for a new release.

@havardholvik
Copy link

Hi there @shinyoshiaki 👋 Do you have an idea when you will be releasing this fix?

@shinyoshiaki
Copy link
Owner

@diogeneshamilton @havardholvik released v0.19.2

@havardholvik
Copy link

havardholvik commented May 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants