-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twoslash renderer not highlighting errors that span multiple tokens #144
Comments
I believe this has two causes:
Here's the error itself as reported by
Using
So this fails in two ways:
It seems like what we'd need to do is apply the error to any token that falls within the range of the error. I'm not super familiar with the codebase though, so I'm not sure what the implications of making that change would be (if any). Happy to tackle this myself if anyone could give me a little direction here. |
I'm trying to render an error for this block of code:
I'm using this
twoslash
block:That block results in this output:
The error output is correct. There are two errors: one on
K
and another onT[Key]
. However, as you can see there's no error squiggly forT[Key]
.Here's what it should look like (screenshot from ts playground):
The text was updated successfully, but these errors were encountered: