Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlareSolverr Support #2081

Open
2 tasks done
ppfeister opened this issue Apr 13, 2024 · 2 comments
Open
2 tasks done

FlareSolverr Support #2081

ppfeister opened this issue Apr 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ppfeister
Copy link
Collaborator

ppfeister commented Apr 13, 2024

Checklist

  • I'm reporting a feature request
  • I've checked for similar feature requests including closed ones

Description

Several years ago, a solution like cloudscraper may have been ideal. Now, there doesn't seem to be any actively maintained solution outside of FlareSolverr. This solution wouldn't be a good build-in, but it can function as a proxy with a couple adjustments.

I was able to put together a somewhat viable proof of concept in #2079 (would be re-engineered if desired, though).

The caveat is that FlareSolverr doesn't seem to properly pass along return codes right now. That would mean it can only be reliably used for message and possibly for redirect_url. When FlareSolverr is detected, we would have status_code requests bypass the proxy and function normally.

Seems that some messages may need a minor tweak depending on how sites handle l10n and such, but they would be similar if changed at all (as in the data.json diff).

Would this partial support be desired, or would we prefer to wait until FlareSolverr more properly supports status_code as well?

@ppfeister
Copy link
Collaborator Author

ppfeister commented Apr 23, 2024

Minor update --

Referencing FlareSolverr/FlareSolverr#1162

Exploring the possibility of opening a PR on FlareSolverr to shoehorn in status code and/or return header support despite Selenium being a PITA. Would be a perfect companion for Sherlock if successful, but who knows if it's even feasible or not yet.


Edited to add:

Paused work on (linked) upstream issue while focusing on another problem, will likely resume soon if of interest.

@asulwer
Copy link

asulwer commented May 13, 2024

this is an issue with Selenium. this issue has been discussed and they are not including support for this.

Selenium Devs say no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants