Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error accessing data.json raw github url #1895

Open
5 tasks done
rpj09 opened this issue Oct 2, 2023 · 2 comments
Open
5 tasks done

Error accessing data.json raw github url #1895

rpj09 opened this issue Oct 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rpj09
Copy link

rpj09 commented Oct 2, 2023

Issue Type: Bug Report

Summary: Error accessing data file URL with improved handling


Checklist

Please make sure to check the following boxes if they apply:

  • I'm reporting a bug in Sherlock's functionality.
  • The bug I'm reporting is not a false positive or a false negative.
  • I've verified that I'm running the latest version of Sherlock.
  • I've checked for similar bug reports, including closed ones.
  • I've checked for pull requests that attempt to fix this bug.

Description

Bug/Error:

ERROR:  Problem while attempting to access data file URL 'https://raw.githubusercontent.com/sherlock-project/sherlock/master/sherlock/resources/data.json':  HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /sherlock-project/sherlock/master/sherlock/resources/data.json (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x11b7cff70>: Failed to establish a new connection: [Errno 60] Operation timed out'))

Issue Description:
When attempting to run Sherlock, users encounter the above error message, preventing them from successfully executing Sherlock. This error occurs when Sherlock is unable to access the data file URL ('https://raw.githubusercontent.com/sherlock-project/sherlock/master/sherlock/resources/data.json').

@bharat-nair
Copy link

@rpj09 this might be due to a network issue, as I had faced something similar. See here for more info:
I Can't access my GitHub (raw.githubusercontent.com) files (Stack Overflow)

Basically, it's an issue in the DNS server of the ISP I am using. Using a VPN or changing your DNS server to Cloudflare/Google should fix it.

@rpj09
Copy link
Author

rpj09 commented Oct 2, 2023

@bharat-nair Yeah, I know that, but in the future, if the issue arises, Sherlock will attempt to load the data.json from the local system, preventing an error. I've also added some additional loggers and visuals to make debugging easier. This not only aids developers but also provides users with a clearer understanding of what Sherlock is doing. Previously, it simply waited for a minute and then gave an error.

@rpj09 rpj09 closed this as completed Oct 2, 2023
@rpj09 rpj09 reopened this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants